components/guest_view/browser/guest_view_base.cc - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from scheib@ Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc ('K') | « chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | content/browser/frame_host/render_frame_host_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/guest_view_base.cc

diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc

index ff69424ebf5fab389fffe399b3dd465793fd6a0a..62712155aa43632dd14a64e31ae2aa7e03efa3ff 100644

--- a/components/guest_view/browser/guest_view_base.cc

+++ b/components/guest_view/browser/guest_view_base.cc

@@ -83,7 +83,8 @@ class GuestViewBase::OwnerContentsObserver : public WebContentsObserver {

Destroy();

}

- void DidToggleFullscreenModeForTab(bool entered_fullscreen) override {

+ void DidToggleFullscreenModeForTab(bool entered_fullscreen,

+ bool will_cause_resize) override {

if (destroyed_)

return;