chrome/browser/ui/chrome_bubble_manager.cc - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_bubble_manager.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trying to fix test broken on Mac Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/chrome_bubble_manager.h ('k') | chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm » ('j') | chrome/browser/ui/exclusive_access/fullscreen_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/chrome_bubble_manager.cc

diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc

index 33890dcaac7b05f5ec654697313cbff70c47e6ef..b6bd676945a0b9dcd4bff0f50f25ad458bf2785c 100644

--- a/chrome/browser/ui/chrome_bubble_manager.cc

+++ b/chrome/browser/ui/chrome_bubble_manager.cc

@@ -134,7 +134,7 @@ void ChromeBubbleManager::ActiveTabChanged(content::WebContents* old_contents,

}

void ChromeBubbleManager::DidToggleFullscreenModeForTab(

- bool entered_fullscreen) {

+ bool entered_fullscreen, bool will_cause_resize) {

CloseAllBubbles(BUBBLE_CLOSE_FULLSCREEN_TOGGLED);

// Any bubble that didn't close should update its anchor position.

UpdateAllBubbleAnchors();