Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Accidentally made will_cause_resize always false in previous cleanup. Fixed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/chrome_bubble_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tab_capture/tab_capture_registry.h" 5 #include "chrome/browser/extensions/api/tab_capture/tab_capture_registry.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE) 109 if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE)
110 registry_->DispatchStatusChangeEvent(this); 110 registry_->DispatchStatusChangeEvent(this);
111 } 111 }
112 112
113 void DidDestroyFullscreenWidget(int routing_id) override { 113 void DidDestroyFullscreenWidget(int routing_id) override {
114 is_fullscreened_ = false; 114 is_fullscreened_ = false;
115 if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE) 115 if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE)
116 registry_->DispatchStatusChangeEvent(this); 116 registry_->DispatchStatusChangeEvent(this);
117 } 117 }
118 118
119 void DidToggleFullscreenModeForTab(bool entered_fullscreen) override { 119 void DidToggleFullscreenModeForTab(bool entered_fullscreen,
120 bool will_cause_resize) override {
120 is_fullscreened_ = entered_fullscreen; 121 is_fullscreened_ = entered_fullscreen;
121 if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE) 122 if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE)
122 registry_->DispatchStatusChangeEvent(this); 123 registry_->DispatchStatusChangeEvent(this);
123 } 124 }
124 125
125 void WebContentsDestroyed() override { 126 void WebContentsDestroyed() override {
126 registry_->KillRequest(this); // Deletes |this|. 127 registry_->KillRequest(this); // Deletes |this|.
127 } 128 }
128 129
129 private: 130 private:
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 it != requests_.end(); ++it) { 364 it != requests_.end(); ++it) {
364 if ((*it) == request) { 365 if ((*it) == request) {
365 requests_.erase(it); 366 requests_.erase(it);
366 return; 367 return;
367 } 368 }
368 } 369 }
369 NOTREACHED(); 370 NOTREACHED();
370 } 371 }
371 372
372 } // namespace extensions 373 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/chrome_bubble_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698