Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1488613007: MIPS: Correct handling of Nan values on MIPS R6 (Closed)

Created:
5 years ago by ivica.bogosavljevic
Modified:
5 years ago
Reviewers:
Ilija.Pavlovic1, djordje.pesic, balazs.kilvady, ilija.pavlovic, paul.l..., akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Correct handling of Nan values on MIPS R6 MIPS R6 introduced new behavior for handling of NaN values for TRUNC, FLOOR, CEIL and CVT instructions. Adding support for the new behavior in MIPS and MIPS64 simulators. Fixing tests for MIPS and MIPS64 to align them with the new behavior. BUG= Committed: https://crrev.com/60d77c8a4378f8af68c384989e4fcbdb4eb062df Cr-Commit-Position: refs/heads/master@{#32499}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing leftover printfs #

Patch Set 3 : Removing leftover printfs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -65 lines) Patch
M src/mips/constants-mips.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 23 chunks +154 lines, -23 lines 0 comments Download
M src/mips64/constants-mips64.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 23 chunks +153 lines, -23 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 2 27 chunks +125 lines, -9 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 27 chunks +123 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ivica.bogosavljevic
5 years ago (2015-12-01 16:26:08 UTC) #3
paul.l...
LGTM, after fixing the nits. https://codereview.chromium.org/1488613007/diff/1/src/mips/simulator-mips.cc File src/mips/simulator-mips.cc (right): https://codereview.chromium.org/1488613007/diff/1/src/mips/simulator-mips.cc#newcode1580 src/mips/simulator-mips.cc:1580: printf("Rounded int = %d\n", ...
5 years ago (2015-12-02 02:49:52 UTC) #4
Ilija.Pavlovic1
lgtm https://codereview.chromium.org/1488613007/diff/1/test/cctest/test-assembler-mips.cc File test/cctest/test-assembler-mips.cc (right): https://codereview.chromium.org/1488613007/diff/1/test/cctest/test-assembler-mips.cc#newcode2299 test/cctest/test-assembler-mips.cc:2299: printf("Type = %d, i = %d\n", j, i); ...
5 years ago (2015-12-02 09:12:17 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488613007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488613007/20001
5 years ago (2015-12-02 10:00:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488613007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488613007/40001
5 years ago (2015-12-02 10:31:55 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 10:51:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488613007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488613007/40001
5 years ago (2015-12-02 10:53:14 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-02 10:54:42 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-02 10:55:32 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60d77c8a4378f8af68c384989e4fcbdb4eb062df
Cr-Commit-Position: refs/heads/master@{#32499}

Powered by Google App Engine
This is Rietveld 408576698