Use LocalStyleChange for element cursor changes in SVG.

Use LocalStyleChange for element cursor changes in SVG.

Propagating the change to the computed cursor property value through
inheritance is handled correctly when using LocalStyleChange. No need to
force a recalc of the whole subtree.

This is part of making sure non of our SubtreeStyleChanges rely on sibling
tree invalidations, and removing unnecessary use of SubtreeStyleChange, so
that we can make SubtreeStyleChange mean subtree only, and not have to
consider the sibling forest.

R=fs@opera.com
BUG=557440
Committed: https://crrev.com/eeb62d1bf832505d2e1b13145e2028bce5acab91
Cr-Commit-Position: refs/heads/master@{#362140}

[rune, 2015-11-30 14:21:18]

ptal

[rune, 2015-11-30 14:22:59]

https://codereview.chromium.org/1488603002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg (right):

https://codereview.chromium.org/1488603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg:4: <rect id="rect"
x="50" y="50" width="100" height="100" fill="green" />
Indentation looks funny.

[rune, 2015-11-30 14:25:37]

On 2015/11/30 14:22:59, rune wrote:
>
https://codereview.chromium.org/1488603002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg (right):
> 
>
https://codereview.chromium.org/1488603002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg:4: <rect
id="rect"
> x="50" y="50" width="100" height="100" fill="green" />
> Indentation looks funny.

Fixed.

[rune, 2015-11-30 14:25:47]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 14:26:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488603002/20001

[fs, 2015-11-30 14:44:39]

Change LGTM, test needs to be tweaked somehow.

https://codereview.chromium.org/1488603002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg (right):

https://codereview.chromium.org/1488603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg:20: if
(getComputedStyle(rect).cursor ==
"url(\"file:///home/rune/dev/src/third_party/WebKit/LayoutTests/svg/css/icon1.ico\"),
auto")
This looks like it won't work too well unless you're not rune. =) Ditto below.

[rune, 2015-11-30 14:50:25]

The CQ bit was unchecked by rune@opera.com

[rune, 2015-11-30 14:51:27]

https://codereview.chromium.org/1488603002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg (right):

https://codereview.chromium.org/1488603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg:20: if
(getComputedStyle(rect).cursor ==
"url(\"file:///home/rune/dev/src/third_party/WebKit/LayoutTests/svg/css/icon1.ico\"),
auto")
On 2015/11/30 14:44:39, fs wrote:
> This looks like it won't work too well unless you're not rune. =) Ditto below.

Ooops :-/

[rune, 2015-11-30 15:08:06]

The CQ bit was checked by rune@opera.com

[rune, 2015-11-30 15:08:06]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1488603002/#ps40001
(title: "Fixed URI paths")

[commit-bot: I haz the power, 2015-11-30 15:08:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488603002/40001

[commit-bot: I haz the power, 2015-11-30 16:25:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-30 16:26:51]

Description was changed from

==========
Use LocalStyleChange for element cursor changes in SVG.

Propagating the change to the computed cursor property value through
inheritance is handled correctly when using LocalStyleChange. No need to
force a recalc of the whole subtree.

This is part of making sure non of our SubtreeStyleChanges rely on sibling
tree invalidations, and removing unnecessary use of SubtreeStyleChange, so
that we can make SubtreeStyleChange mean subtree only, and not have to
consider the sibling forest.

R=fs@opera.com
BUG=557440
==========

to

==========
Use LocalStyleChange for element cursor changes in SVG.

Propagating the change to the computed cursor property value through
inheritance is handled correctly when using LocalStyleChange. No need to
force a recalc of the whole subtree.

This is part of making sure non of our SubtreeStyleChanges rely on sibling
tree invalidations, and removing unnecessary use of SubtreeStyleChange, so
that we can make SubtreeStyleChange mean subtree only, and not have to
consider the sibling forest.

R=fs@opera.com
BUG=557440

Committed: https://crrev.com/eeb62d1bf832505d2e1b13145e2028bce5acab91
Cr-Commit-Position: refs/heads/master@{#362140}
==========

[commit-bot: I haz the power, 2015-11-30 16:26:52]

Patchset 3 (id:??) landed as
https://crrev.com/eeb62d1bf832505d2e1b13145e2028bce5acab91
Cr-Commit-Position: refs/heads/master@{#362140}