src/snapshot/serialize.cc - Issue 1488593003: Optimize clearing of map transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/serialize.cc

Issue 1488593003: Optimize clearing of map transitions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot/serialize.cc

diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc

index 526d530baa90ae68d3ee0680097ea23903126447..b729e60c6099add743de2b16e4232bf483cc9130 100644

--- a/src/snapshot/serialize.cc

+++ b/src/snapshot/serialize.cc

@@ -1919,7 +1919,7 @@ class UnlinkWeakCellScope {

if (object->IsWeakCell()) {

weak_cell_ = WeakCell::cast(object);

next_ = weak_cell_->next();

- weak_cell_->clear_next(object->GetHeap());

+ weak_cell_->clear_next(object->GetHeap()->the_hole_value());

}

« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »