Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: src/objects-inl.h

Issue 1488593003: Optimize clearing of map transitions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: base Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index df56d5ce5b14260ad439532e45f1ceda5cb473ca..e85df8e51bfce7169fd464f438fcfa76f2e865c6 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -2080,8 +2080,8 @@ void WeakCell::set_next(Object* val, WriteBarrierMode mode) {
}
-void WeakCell::clear_next(Heap* heap) {
- set_next(heap->the_hole_value(), SKIP_WRITE_BARRIER);
+void WeakCell::clear_next(Object* the_hole_value) {
+ set_next(the_hole_value, SKIP_WRITE_BARRIER);
Hannes Payer (out of office) 2015/12/08 14:19:41 Let's DCHECK that the_hole_value is the hole value
ulan 2015/12/08 16:25:04 Done.
}
@@ -5506,8 +5506,7 @@ void Map::set_prototype_info(Object* value, WriteBarrierMode mode) {
void Map::SetBackPointer(Object* value, WriteBarrierMode mode) {
DCHECK(instance_type() >= FIRST_JS_RECEIVER_TYPE);
- DCHECK((value->IsUndefined() && GetBackPointer()->IsMap()) ||
- (value->IsMap() && GetBackPointer()->IsUndefined()));
+ DCHECK((value->IsMap() && GetBackPointer()->IsUndefined()));
DCHECK(!value->IsMap() ||
Map::cast(value)->GetConstructor() == constructor_or_backpointer());
set_constructor_or_backpointer(value, mode);

Powered by Google App Engine
This is Rietveld 408576698