src/heap/heap.cc - Issue 1488593003: Optimize clearing of map transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1488593003: Optimize clearing of map transitions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: base Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 2f017c2c0bdc8f004f3372ccde358ad2613fe365..83f12dfddbef51b9f4b47df6c2863bbb2f5189d6 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -2491,7 +2491,7 @@ AllocationResult Heap::AllocateWeakCell(HeapObject* value) {

}

result->set_map_no_write_barrier(weak_cell_map());

WeakCell::cast(result)->initialize(value);

- WeakCell::cast(result)->clear_next(this);

+ WeakCell::cast(result)->clear_next(the_hole_value());

return result;

}