Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1488563002: Mark soon-to-be-deprecated TryCatch ctor as deprecated (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark soon-to-be-deprecated TryCatch ctor as deprecated BUG=none R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/17b4e7450d84a78b23c0baa8b524248d0de08c9a Cr-Commit-Position: refs/heads/master@{#32451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-30 13:48:52 UTC) #1
vogelheim
lgtm
5 years ago (2015-11-30 14:46:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488563002/1
5 years ago (2015-12-01 10:36:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 10:58:07 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 10:58:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/17b4e7450d84a78b23c0baa8b524248d0de08c9a
Cr-Commit-Position: refs/heads/master@{#32451}

Powered by Google App Engine
This is Rietveld 408576698