Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1488553002: [turbofan] Fewer gap moves for tail calls (Closed)

Created:
5 years ago by danno
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fewer gap moves for tail calls Restore frame pointer directly from stack rather than copying it and restoring. Also restore return address register directly on platforms that support it. BUG=v8:4076 LOG=n Committed: https://crrev.com/51e992f147b0f3c3763947655844915294de10e5 Cr-Commit-Position: refs/heads/master@{#32410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -53 lines) Patch
M src/base/build_config.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +5 lines, -26 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danno
PTAL
5 years ago (2015-11-30 13:39:13 UTC) #2
Benedikt Meurer
LGTM.
5 years ago (2015-11-30 14:33:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488553002/1
5 years ago (2015-11-30 14:34:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 14:42:13 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 14:42:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51e992f147b0f3c3763947655844915294de10e5
Cr-Commit-Position: refs/heads/master@{#32410}

Powered by Google App Engine
This is Rietveld 408576698