Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1488543002: DocumentMarkerControllerTest: drop unnecessary caching of Document reference. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
haraken, yosin_UTC9
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DocumentMarkerControllerTest: drop unnecessary caching of Document reference. Tidying; no need to use a strong reference to the page's document here. R=haraken BUG= Committed: https://crrev.com/206444b3d0dba0640e8d98ee4bc2561f67579fb2 Cr-Commit-Position: refs/heads/master@{#362125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. Incidental tidying while chasing after some reported memory leaks. (Not that ...
5 years ago (2015-11-30 12:55:49 UTC) #2
haraken
LGTM
5 years ago (2015-11-30 13:37:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488543002/1
5 years ago (2015-11-30 13:42:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 13:46:02 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-30 13:47:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/206444b3d0dba0640e8d98ee4bc2561f67579fb2
Cr-Commit-Position: refs/heads/master@{#362125}

Powered by Google App Engine
This is Rietveld 408576698