Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html

Issue 1488493003: [css-grid] refactoring of layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/place-cell-by-index.html » ('j') | third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html
index 3756a1e0f70db2a315cb81466edf97549c22051c..661ad2729516975a37fe341f6d4a119ee2591136 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html
@@ -1,6 +1,8 @@
<!DOCTYPE html>
<html>
<head>
+<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel="stylesheet">
+<link href="../css-intrinsic-dimensions/resources/height-keyword-classes.css" rel="stylesheet">
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
@@ -23,16 +25,10 @@
height: 50%;
}
-.indefiniteSize {
- width: -webkit-fit-content;
+.indefiniteHeight {
height: auto;
Manuel Rego 2015/12/02 09:31:02 height is "auto" by default, I don't think you nee
jfernandez 2015/12/03 15:06:11 Yes, we do need it. The issue is when we setup fit
Manuel Rego 2015/12/04 13:12:43 True as you're using both width-keyword-classes.cs
svillar 2015/12/04 13:18:31 In this case I also think is better to explicitly
}
-.fitContentSize {
- width: fit-content;
- height: fit-content;
-}
-
.firstRowFirstColumn {
color: blue;
background-color: cyan;
@@ -62,7 +58,7 @@
</div>
</div>
- <div class="indefiniteSize">
+ <div class="fit-content indefiniteHeight">
<div class="grid">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
@@ -78,7 +74,7 @@
</div>
</div>
- <div class="indefiniteSize">
+ <div class="indefiniteHeight">
<div class="grid fixedSize">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="80" data-expected-height="160">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="200" data-expected-height="160">XXXXX</div>
@@ -86,7 +82,7 @@
</div>
</div>
- <div class="indefiniteSize">
+ <div class="fit-content indefiniteHeight">
<div class="grid calculatedSize">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
@@ -102,7 +98,7 @@
</div>
</div>
- <div class="indefiniteSize">
+ <div class="fit-content indefiniteHeight">
<div class="grid percentageSize">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
@@ -118,8 +114,8 @@
</div>
</div>
- <div class="indefiniteSize">
- <div class="grid indefiniteSize">
+ <div class="fit-content indefiniteHeight">
+ <div class="grid fit-content indefiniteHeight">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
<div class="firstRowThirdColumn sizedToGridArea" data-expected-width="30" data-expected-height="10">XXX</div>
@@ -127,15 +123,15 @@
</div>
<div class="unconstrainedContainer">
- <div class="grid indefiniteSize">
+ <div class="grid fit-content indefiniteHeight">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
<div class="firstRowThirdColumn sizedToGridArea" data-expected-width="30" data-expected-height="10">XXX</div>
</div>
</div>
- <div class="indefiniteSize">
- <div class="grid fitContentSize">
+ <div class="indefiniteHeight fit-content">
+ <div class="grid fit-content">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
<div class="firstRowThirdColumn sizedToGridArea" data-expected-width="30" data-expected-height="10">XXX</div>
@@ -143,7 +139,7 @@
</div>
<div class="unconstrainedContainer">
- <div class="grid fitContentSize">
+ <div class="grid fit-content">
<div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>
<div class="firstRowSecondColumn sizedToGridArea" data-expected-width="50" data-expected-height="10">XXXXX</div>
<div class="firstRowThirdColumn sizedToGridArea" data-expected-width="30" data-expected-height="10">XXX</div>
« third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/place-cell-by-index.html » ('j') | third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698