[css-grid] refactoring of layout tests

third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html
index de8096fd0be84ae80c0167421b40516a6c6040d5..5bd3ba71b0f7cfd4d4ea160a99d4bedb93078b8d 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html
@@ -6,6 +6,10 @@
     grid-template-columns: 200px 200px;
     grid-template-rows: 200px 200px;
 }
+.container {
+    width: 600px;
+    height: 600px;
+}

[Manuel Rego, 2015/12/02 09:31:01]

This change is unrelated to prefixes, it's about different viewport sizes.
Maybe you want to add a line about that in the patch description.
Or do this particular change in a different patch.

[jfernandez, 2015/12/03 15:06:11]

Umm, this change could indeed be done in a different patch, I agree.

 
 #absolutePos {
    position: absolute;
@@ -51,32 +55,40 @@
 <p>This test checks that the shrink-to-fit behavior is applied to the float and out-of-flow positioned elements.</p>
 <p>The following grids should be 400px * 400px, except the first one which uses 'relative' positioning.</p>
 
-<div class="grid" id="regularGrid" data-expected-height="400" data-expected-width="769">
-  <div id="one"></div>
-  <div id="two"></div>
-  <div id="three"></div>
-  <div id="four"></div>
+<div class="container">
+    <div class="grid" id="regularGrid" data-expected-height="400" data-expected-width="600">
+        <div id="one"></div>
+        <div id="two"></div>
+        <div id="three"></div>
+        <div id="four"></div>
+    </div>
 </div>
 
-<div class="grid" id="absolutePos" data-expected-height="400" data-expected-width="400">
-  <div class="gg" id="one"></div>
-  <div class="gg" id="two"></div>
-  <div class="gg" id="three"></div>
-  <div class="gg" id="four"></div>
+<div class="container">

[Manuel Rego, 2015/12/02 09:31:01]

I think you don't need the container here.

[jfernandez, 2015/12/03 15:06:11]

umm, I don't agree. the idea of this patch is to verify the shrink-to-fit
behavior, hence we would need to have a container reference. If we don't set it
here, we will us the viewport. I think all the test cases must be identical,
just changing the positioning scheme. 

[Manuel Rego, 2015/12/04 13:12:43]

Fair enough.

+    <div class="grid" id="absolutePos" data-expected-height="400" data-expected-width="400">
+        <div id="one"></div>
+        <div id="two"></div>
+        <div id="three"></div>
+        <div id="four"></div>
+    </div>
 </div>
 
-<div class="grid" id="fixedPos" data-expected-height="400" data-expected-width="400">
-  <div class="gg" id="one"></div>
-  <div class="gg" id="two"></div>
-  <div class="gg" id="three"></div>
-  <div class="gg" id="four"></div>
+<div class="container">

[Manuel Rego, 2015/12/02 09:31:01]

Ditto.

+    <div class="grid" id="fixedPos" data-expected-height="400" data-expected-width="400">
+        <div id="one"></div>
+        <div id="two"></div>
+        <div id="three"></div>
+        <div id="four"></div>
+    </div>
 </div>
 
-<div class="grid" id="floatPos" data-expected-height="400" data-expected-width="400">
-  <div class="gg" id="one"></div>
-  <div class="gg" id="two"></div>
-  <div class="gg" id="three"></div>
-  <div class="gg" id="four"></div>
+<div class="container">

[Manuel Rego, 2015/12/02 09:31:02]

Ditto.

+    <div class="grid" id="floatPos" data-expected-height="400" data-expected-width="400">
+        <div id="one"></div>
+        <div id="two"></div>
+        <div id="three"></div>
+        <div id="four"></div>
+    </div>
 </div>
 
 </body>