Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: chrome/browser/chromeos/settings/cros_settings_unittest.cc

Issue 148843002: Make an online wildcard login check for enterprise devices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/cros_settings_unittest.cc
diff --git a/chrome/browser/chromeos/settings/cros_settings_unittest.cc b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
index d328b589a4c230c15be291d565d0126ba47efeb8..906a248c1eefcdba2afa81c7e062784a2f05907f 100644
--- a/chrome/browser/chromeos/settings/cros_settings_unittest.cc
+++ b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
@@ -88,6 +88,10 @@ class CrosSettingsTest : public testing::Test {
response.set_policy_data_signature("false");
}
+ static bool IsWhitelisted(CrosSettings* cs, const std::string& username) {
+ return cs->FindEmailInList(kAccountsPrefUsers, username, NULL);
+ }
+
base::MessageLoopForUI message_loop_;
content::TestBrowserThread ui_thread_;
@@ -230,25 +234,25 @@ TEST_F(CrosSettingsTest, FindEmailInList) {
CrosSettings* cs = &settings_;
cs->Set(kAccountsPrefUsers, list);
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "user@example.com"));
- EXPECT_FALSE(cs->FindEmailInList(kAccountsPrefUsers, "us.er@example.com"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "USER@example.com"));
- EXPECT_FALSE(cs->FindEmailInList(kAccountsPrefUsers, "user"));
-
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "nodomain"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "nodomain@gmail.com"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "no.domain@gmail.com"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "NO.DOMAIN"));
-
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "with.dots@gmail.com"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "withdots@gmail.com"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "WITH.DOTS@gmail.com"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "WITHDOTS"));
-
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "Upper@example.com"));
- EXPECT_FALSE(cs->FindEmailInList(kAccountsPrefUsers, "U.pper@example.com"));
- EXPECT_FALSE(cs->FindEmailInList(kAccountsPrefUsers, "Upper"));
- EXPECT_TRUE(cs->FindEmailInList(kAccountsPrefUsers, "upper@example.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "user@example.com"));
+ EXPECT_FALSE(IsWhitelisted(cs, "us.er@example.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "USER@example.com"));
+ EXPECT_FALSE(IsWhitelisted(cs, "user"));
+
+ EXPECT_TRUE(IsWhitelisted(cs, "nodomain"));
+ EXPECT_TRUE(IsWhitelisted(cs, "nodomain@gmail.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "no.domain@gmail.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "NO.DOMAIN"));
+
+ EXPECT_TRUE(IsWhitelisted(cs, "with.dots@gmail.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "withdots@gmail.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "WITH.DOTS@gmail.com"));
+ EXPECT_TRUE(IsWhitelisted(cs, "WITHDOTS"));
+
+ EXPECT_TRUE(IsWhitelisted(cs, "Upper@example.com"));
+ EXPECT_FALSE(IsWhitelisted(cs, "U.pper@example.com"));
+ EXPECT_FALSE(IsWhitelisted(cs, "Upper"));
+ EXPECT_TRUE(IsWhitelisted(cs, "upper@example.com"));
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698