chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc - Issue 148843002: Make an online wildcard login check for enterprise devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

Issue 148843002: Make an online wildcard login check for enterprise devices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Joao's comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc ('K') | « chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc » ('j') | chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

index d5b8e5ca4b394d32c621ba3c657ed9d9294a265a..c7d976e6f41a6372708cdd4f727fc328dc394311 100644

--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

@@ -15,6 +15,7 @@

#include "base/threading/sequenced_worker_pool.h"

#include "base/time/time.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/chromeos/login/login_utils.h"

#include "chrome/browser/chromeos/login/user.h"

#include "chrome/browser/chromeos/login/user_manager.h"

#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"

@@ -199,6 +200,15 @@ scoped_ptr<UserCloudPolicyManagerChromeOS>

base::MessageLoopProxy::current(),

file_task_runner,

io_task_runner));

+ bool wildcard_match = false;

+ if (connector->IsEnterpriseManaged() &&

+ chromeos::LoginUtils::IsWhitelisted(username, &wildcard_match) &&

+ wildcard_match &&

+ !connector->IsNonEnterpriseUser(username)) {

+ manager->EnableWildcardLoginCheck(username);

+ }

manager->Init(SchemaRegistryServiceFactory::GetForContext(profile));

manager->Connect(g_browser_process->local_state(),

device_management_service,