Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: chrome/browser/safe_browsing/ui_manager.h

Issue 1488423002: Don't collect safebrowsing DOM details if the warning was main page load blocking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The Safe Browsing service is responsible for downloading anti-phishing and 5 // The Safe Browsing service is responsible for downloading anti-phishing and
6 // anti-malware tables and checking urls against them. 6 // anti-malware tables and checking urls against them.
7 7
8 #ifndef CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_ 8 #ifndef CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_
9 #define CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_ 9 #define CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_
10 10
(...skipping 28 matching lines...) Expand all
39 // Passed a boolean indicating whether or not it is OK to proceed with 39 // Passed a boolean indicating whether or not it is OK to proceed with
40 // loading an URL. 40 // loading an URL.
41 typedef base::Callback<void(bool /*proceed*/)> UrlCheckCallback; 41 typedef base::Callback<void(bool /*proceed*/)> UrlCheckCallback;
42 42
43 // Structure used to pass parameters between the IO and UI thread when 43 // Structure used to pass parameters between the IO and UI thread when
44 // interacting with the blocking page. 44 // interacting with the blocking page.
45 struct UnsafeResource { 45 struct UnsafeResource {
46 UnsafeResource(); 46 UnsafeResource();
47 ~UnsafeResource(); 47 ~UnsafeResource();
48 48
49 bool IsMainPageLoadBlocked() const;
50
49 GURL url; 51 GURL url;
50 GURL original_url; 52 GURL original_url;
51 std::vector<GURL> redirect_urls; 53 std::vector<GURL> redirect_urls;
52 bool is_subresource; 54 bool is_subresource;
53 bool is_subframe; 55 bool is_subframe;
54 SBThreatType threat_type; 56 SBThreatType threat_type;
55 std::string threat_metadata; 57 std::string threat_metadata;
56 UrlCheckCallback callback; // This is called back on the IO thread. 58 UrlCheckCallback callback; // This is called back on the IO thread.
57 int render_process_host_id; 59 int render_process_host_id;
58 int render_view_id; 60 int render_view_id;
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 scoped_refptr<SafeBrowsingService> sb_service_; 157 scoped_refptr<SafeBrowsingService> sb_service_;
156 158
157 base::ObserverList<Observer> observer_list_; 159 base::ObserverList<Observer> observer_list_;
158 160
159 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingUIManager); 161 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingUIManager);
160 }; 162 };
161 163
162 } // namespace safe_browsing 164 } // namespace safe_browsing
163 165
164 #endif // CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_ 166 #endif // CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698