Don't collect safebrowsing DOM details if the warning was main page load blocking.

Don't collect safebrowsing DOM details if the warning was main page load blocking.

BUG=564409
Committed: https://crrev.com/e385710b34b3735b1a767017076e3c669d724e7b
Cr-Commit-Position: refs/heads/master@{#363074}

[mattm, 2015-12-02 05:46:15]

mattm@chromium.org changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2015-12-02 22:05:23]

lgtm

+jialiul since she's working on RVH->RFH refactoring for this code.

https://codereview.chromium.org/1488423002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1488423002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:767: LOG(INFO)
<< "expect_threat_details: " << expect_threat_details;
Do you still need this LOG (and below)?

[Jialiu Lin, 2015-12-02 22:13:29]

On 2015/12/02 22:05:23, nparker wrote:
> lgtm
> 
> +jialiul since she's working on RVH->RFH refactoring for this code.
> 
>
https://codereview.chromium.org/1488423002/diff/1/chrome/browser/safe_browsin...
> File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):
> 
>
https://codereview.chromium.org/1488423002/diff/1/chrome/browser/safe_browsin...
> chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:767:
LOG(INFO)
> << "expect_threat_details: " << expect_threat_details;
> Do you still need this LOG (and below)?

Thanks for taking care of this bug, mattm! Still working the RVH->RFH
refactoring bug. It now seems to be a much more complicated change than I
thought. I might bug you at some point. 
And thanks nparker for cc'ing me.

[mattm, 2015-12-02 23:20:38]

Description was changed from

==========
Don't collect safebrowsing DOM details if the warning was main page load
blocking.

BUG=564409
==========

to

==========
Don't collect safebrowsing DOM details if the warning was main page load
blocking.

BUG=564409
==========

[mattm, 2015-12-02 23:20:48]

https://codereview.chromium.org/1488423002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1488423002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:767: LOG(INFO)
<< "expect_threat_details: " << expect_threat_details;
On 2015/12/02 22:05:23, nparker wrote:
> Do you still need this LOG (and below)?

nope, just missed these ones. fixed.

[mattm, 2015-12-02 23:21:13]

The CQ bit was checked by mattm@chromium.org

[mattm, 2015-12-02 23:21:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1488423002/#ps20001
(title: "remove log lines")

[commit-bot: I haz the power, 2015-12-02 23:22:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488423002/20001

[commit-bot: I haz the power, 2015-12-03 03:40:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 03:40:44]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[mattm, 2015-12-03 03:46:53]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2015-12-03 03:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488423002/20001

[commit-bot: I haz the power, 2015-12-03 06:12:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 06:12:22]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[mattm, 2015-12-03 19:02:42]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2015-12-03 19:05:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488423002/20001

[commit-bot: I haz the power, 2015-12-03 22:36:59]

Description was changed from

==========
Don't collect safebrowsing DOM details if the warning was main page load
blocking.

BUG=564409
==========

to

==========
Don't collect safebrowsing DOM details if the warning was main page load
blocking.

BUG=564409
==========

[commit-bot: I haz the power, 2015-12-03 22:37:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 22:38:11]

Description was changed from

==========
Don't collect safebrowsing DOM details if the warning was main page load
blocking.

BUG=564409
==========

to

==========
Don't collect safebrowsing DOM details if the warning was main page load
blocking.

BUG=564409

Committed: https://crrev.com/e385710b34b3735b1a767017076e3c669d724e7b
Cr-Commit-Position: refs/heads/master@{#363074}
==========

[commit-bot: I haz the power, 2015-12-03 22:38:11]

Patchset 2 (id:??) landed as
https://crrev.com/e385710b34b3735b1a767017076e3c669d724e7b
Cr-Commit-Position: refs/heads/master@{#363074}