Precompilation/x64: Load float vector constants via Thread.

runtime/vm/assembler_x64_test.cc

Index: runtime/vm/assembler_x64_test.cc
diff --git a/runtime/vm/assembler_x64_test.cc b/runtime/vm/assembler_x64_test.cc
index a78f3ca6c3030b812bfed4ff71740f5378d69c38..0517209c83137dd520c3c623dbac5bc653d12de7 100644
--- a/runtime/vm/assembler_x64_test.cc
+++ b/runtime/vm/assembler_x64_test.cc
@@ -2021,16 +2021,21 @@ ASSEMBLER_TEST_RUN(PackedDoubleSub, test) {
 
 
 static void EnterTestFrame(Assembler* assembler) {
+  COMPILE_ASSERT(THR != CallingConventions::kArg1Reg);
+  COMPILE_ASSERT(CODE_REG != CallingConventions::kArg2Reg);
   __ EnterFrame(0);
   __ pushq(CODE_REG);
   __ pushq(PP);
+  __ pushq(THR);
   __ movq(CODE_REG, Address(CallingConventions::kArg1Reg,
                             VMHandles::kOffsetOfRawPtrInHandle));
+  __ movq(THR, CallingConventions::kArg2Reg);
   __ LoadPoolPointer(PP);
 }
 
 
 static void LeaveTestFrame(Assembler* assembler) {
+  __ popq(THR);
   __ popq(PP);
   __ popq(CODE_REG);
   __ LeaveFrame();
@@ -2053,7 +2058,7 @@ ASSEMBLER_TEST_GENERATE(PackedDoubleNegate, assembler) {
 
 
 ASSEMBLER_TEST_RUN(PackedDoubleNegate, test) {
-  double res = test->InvokeWithCode<double>();
+  double res = test->InvokeWithCodeAndThread<double>();
   EXPECT_FLOAT_EQ(-1.0, res, 0.000001f);
 }
 
@@ -2074,7 +2079,7 @@ ASSEMBLER_TEST_GENERATE(PackedDoubleAbsolute, assembler) {
 
 
 ASSEMBLER_TEST_RUN(PackedDoubleAbsolute, test) {
-  double res = test->InvokeWithCode<double>();
+  double res = test->InvokeWithCodeAndThread<double>();
   EXPECT_FLOAT_EQ(1.0, res, 0.000001f);
 }
 
@@ -2520,7 +2525,7 @@ ASSEMBLER_TEST_GENERATE(PackedNegate, assembler) {
 
 
 ASSEMBLER_TEST_RUN(PackedNegate, test) {
-  float res = test->InvokeWithCode<float>();
+  float res = test->InvokeWithCodeAndThread<float>();
   EXPECT_FLOAT_EQ(-12.3f, res, 0.001f);
 }
 
@@ -2538,7 +2543,7 @@ ASSEMBLER_TEST_GENERATE(PackedAbsolute, assembler) {
 
 
 ASSEMBLER_TEST_RUN(PackedAbsolute, test) {
-  float res = test->InvokeWithCode<float>();
+  float res = test->InvokeWithCodeAndThread<float>();
   EXPECT_FLOAT_EQ(15.3f, res, 0.001f);
 }
 
@@ -2554,7 +2559,7 @@ ASSEMBLER_TEST_GENERATE(PackedSetWZero, assembler) {
 
 
 ASSEMBLER_TEST_RUN(PackedSetWZero, test) {
-  float res = test->InvokeWithCode<float>();
+  float res = test->InvokeWithCodeAndThread<float>();
   EXPECT_FLOAT_EQ(0.0f, res, 0.001f);
 }
 
@@ -2678,7 +2683,7 @@ ASSEMBLER_TEST_GENERATE(PackedLogicalNot, assembler) {
 
 
 ASSEMBLER_TEST_RUN(PackedLogicalNot, test) {
-  uint32_t res = test->InvokeWithCode<uint32_t>();
+  uint32_t res = test->InvokeWithCodeAndThread<uint32_t>();
   EXPECT_EQ(static_cast<uword>(0x0), res);
 }
 
@@ -3103,7 +3108,7 @@ ASSEMBLER_TEST_GENERATE(TestObjectCompare, assembler) {
 
 
 ASSEMBLER_TEST_RUN(TestObjectCompare, test) {
-  bool res = test->InvokeWithCode<bool>();
+  bool res = test->InvokeWithCodeAndThread<bool>();
   EXPECT_EQ(true, res);
 }
 
@@ -3416,8 +3421,8 @@ ASSEMBLER_TEST_GENERATE(DoubleAbs, assembler) {
   EnterTestFrame(assembler);
 #if defined(TARGET_OS_WINDOWS)
   // First argument is code object, MSVC passes second argument in XMM1.

[Florian Schneider, 2015/12/03 11:32:28]

Change comment accordingly - i.e. MSVC uses XMMn if argument n is a double -
starting from 0.

[rmacnak, 2015/12/03 21:26:07]

Done.

-  __ DoubleAbs(XMM1);
-  __ movaps(XMM0, XMM1);
+  __ DoubleAbs(XMM2);
+  __ movaps(XMM0, XMM2);
 #else
   __ DoubleAbs(XMM0);
 #endif
@@ -3428,10 +3433,10 @@ ASSEMBLER_TEST_GENERATE(DoubleAbs, assembler) {
 
 ASSEMBLER_TEST_RUN(DoubleAbs, test) {
   double val = -12.45;
-  double res =  test->InvokeWithCode<double, double>(val);
+  double res =  test->InvokeWithCodeAndThread<double, double>(val);
   EXPECT_FLOAT_EQ(-val, res, 0.001);
   val = 12.45;
-  res = test->InvokeWithCode<double, double>(val);
+  res = test->InvokeWithCodeAndThread<double, double>(val);
   EXPECT_FLOAT_EQ(val, res, 0.001);
 }