Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1488403002: Precompilation/x64: Load float vector constants via Thread. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation/x64: Load float vector constants via Thread. Cannot put these in the object pool because some of these instructions are used in intrinsics. BUG=http://dartbug.com/24450 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/9cf30c9697afdf480b09133d80436f1a23228af7

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -117 lines) Patch
M runtime/vm/assembler_arm64_test.cc View 10 chunks +13 lines, -26 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 4 chunks +16 lines, -64 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 2 10 chunks +20 lines, -12 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +12 lines, -2 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
5 years ago (2015-12-02 02:03:29 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/1488403002/diff/1/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (right): https://codereview.chromium.org/1488403002/diff/1/runtime/vm/assembler_x64_test.cc#newcode3423 runtime/vm/assembler_x64_test.cc:3423: // First argument is code object, MSVC passes ...
5 years ago (2015-12-03 11:32:28 UTC) #3
rmacnak
https://codereview.chromium.org/1488403002/diff/1/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (right): https://codereview.chromium.org/1488403002/diff/1/runtime/vm/assembler_x64_test.cc#newcode3423 runtime/vm/assembler_x64_test.cc:3423: // First argument is code object, MSVC passes second ...
5 years ago (2015-12-03 21:26:08 UTC) #4
rmacnak
5 years ago (2015-12-03 21:35:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9cf30c9697afdf480b09133d80436f1a23228af7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698