Issue 14884015: drive: Remove DriveFileType

Issue 14884015: drive: Remove DriveFileType (Closed)

Created:
7 years, 7 months ago by hashimoto

Modified:
7 years, 7 months ago

Reviewers:
hidehiko, Matt Perry, Evan Stade

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, kinaba

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Remove DriveFileType DriveFileSpecificInfo::is_hosted_document can replace DriveFileType. BUG=None TEST=build R=estade@chromium.org, hidehiko@chromium.org, mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198858

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -112 lines)			Patch
M	chrome/browser/chromeos/drive/file_system.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system.cc	View	1	7 chunks	+9 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.h	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_interface.h	View	1	2 chunks	+1 line, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_proxy.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1	8 chunks	+33 lines, -33 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client_unittest.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc	View	1 2	4 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/platform_app_launcher.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/screenshot_source.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/screenshot_source.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14884015/9001

7 years, 7 months ago (2013-05-07 09:24:35 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1761

7 years, 7 months ago (2013-05-07 09:34:04 UTC) #4

hashimoto

mpcomplete@: Please review chrome/browser/extensions/platform_app_launcher.cc as an owner. estade@: Please review chrome/browser/ui/webui/screenshot_source.* as an owner.

7 years, 7 months ago (2013-05-07 10:35:14 UTC) #5

hashimoto

7 years, 7 months ago (2013-05-08 07:27:22 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r198858 (presubmit successful).

Expand Messages | Collapse Messages