Issue 14884011: by hook or by crook, force gcc to return the value of SkPoint::length() to actually be a float

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14884011: by hook or by crook, force gcc to return the value of SkPoint::length() to actually be a float (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

by hook or by crook, force gcc to return the value of SkPoint::length() to actually be a float instead of a double. Otherwise we can't properly test for overflow with large values. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9015

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	trunk/tests/PointTest.cpp	View		2 chunks	+22 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits https://codereview.chromium.org/14884011/diff/1/trunk/tests/PointTest.cpp File trunk/tests/PointTest.cpp (right): https://codereview.chromium.org/14884011/diff/1/trunk/tests/PointTest.cpp#newcode63 trunk/tests/PointTest.cpp:63: propagate https://codereview.chromium.org/14884011/diff/1/trunk/tests/PointTest.cpp#newcode67 trunk/tests/PointTest.cpp:67: // rm "must"?

7 years, 7 months ago (2013-05-06 15:42:23 UTC) #2

reed1

7 years, 7 months ago (2013-05-06 15:59:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9015 (presubmit successful).

Expand Messages | Collapse Messages