Mask orientation and layout correctly.

src/ports/SkFontHost_mac.cpp

Index: src/ports/SkFontHost_mac.cpp
===================================================================
--- src/ports/SkFontHost_mac.cpp	(revision 9015)
+++ src/ports/SkFontHost_mac.cpp	(working copy)
@@ -1832,8 +1832,17 @@
 }
 
 void SkTypeface_Mac::onFilterRec(SkScalerContextRec* rec) const {
-    unsigned flagsWeDontSupport = SkScalerContext::kDevKernText_Flag |
-                                  SkScalerContext::kAutohinting_Flag;
+    if (rec->fFlags & SkScalerContext::kLCD_BGROrder_Flag ||
+        rec->fFlags & SkScalerContext::kLCD_Vertical_Flag)
+    {
+        rec->fMaskFormat = SkMask::kA8_Format;
+        rec->setHinting(SkPaint::kNormal_Hinting);

[reed1, 2013/05/06 18:02:12]

why do we explicitly set hinting in this case?

[bungeman-skia, 2013/05/06 18:16:10]

Added comment. The issue is that LCD no-hinting means LCD with-dilation, whereas
A8 no-hinting means A8 no-dilation. Setting the hinting to 'normal' here means
that the A8 generated will be A8 with-dilation, the closest possible match to
the LCD we would have otherwise drawn.

+    }
+    
+    unsigned flagsWeDontSupport = SkScalerContext::kDevKernText_Flag  |
+                                  SkScalerContext::kAutohinting_Flag  |
+                                  SkScalerContext::kLCD_BGROrder_Flag |
+                                  SkScalerContext::kLCD_Vertical_Flag;
 
     rec->fFlags &= ~flagsWeDontSupport;