Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1488393003: Reland of [heap] Cleanup mark bit usage. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Cleanup mark bit usage. (patchset #1 id:1 of https://codereview.chromium.org/1490753003/ ) Reason for revert: Reland after fixing the potential root cause of the canary crasher. Original issue's description: > Revert of [heap] Cleanup mark bit usage. (patchset #1 id:1 of https://codereview.chromium.org/1474203003/ ) > > Reason for revert: > Still investigating bad canary. > > Original issue's description: > > [heap] Cleanup mark bit usage. > > > > BUG= > > > > Committed: https://crrev.com/5874ac783ff9bc4bb4b2fda81f5077f06619f96c > > Cr-Commit-Position: refs/heads/master@{#32362} > > TBR=mlippautz@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/d3faef8658598e68331208b5a1846ac1c250cb49 > Cr-Commit-Position: refs/heads/master@{#32461} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0240d202651c89a93fdf2b50bf06bedb4e603b9a Cr-Commit-Position: refs/heads/master@{#32502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M src/heap/mark-compact.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Hannes Payer (out of office)
Created Reland of [heap] Cleanup mark bit usage.
5 years ago (2015-12-02 11:03:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488393003/1
5 years ago (2015-12-02 11:03:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 11:05:22 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-02 11:06:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0240d202651c89a93fdf2b50bf06bedb4e603b9a
Cr-Commit-Position: refs/heads/master@{#32502}

Powered by Google App Engine
This is Rietveld 408576698