Replace multi-value keyboard flags with single value flag types.

Replace multi-value keyboard flags with single value flag types.

Use the new disable value flags to replace multi-value keyboard flags. This has
the property that the multi-value flag had (can change without a string update)
and makes it clear to the user which value is default.

BUG=245319
Committed: https://crrev.com/512a1038bac66e0afae60e7431f88e39ccf3e120
Cr-Commit-Position: refs/heads/master@{#363484}

[flackr, 2015-12-03 21:54:13]

flackr@chromium.org changed reviewers:
+ rsadam@chromium.org

[flackr, 2015-12-03 21:54:13]

PTAL, thanks.

[rsadam, 2015-12-04 01:19:36]

On 2015/12/03 21:54:13, flackr wrote:
> PTAL, thanks.

lgtm

You'll probably need bshe@ for OWNERS.

[flackr, 2015-12-04 14:22:28]

flackr@chromium.org changed reviewers:
+ bshe@chromium.org

[flackr, 2015-12-04 14:22:28]

+bshe, PTAL thanks

[flackr, 2015-12-04 14:23:27]

flackr@chromium.org changed reviewers:
+ oshima@chromium.org

[flackr, 2015-12-04 14:23:27]

+oshima for trivial change in virtual keyboard controller test.

[bshe, 2015-12-04 14:47:10]

On 2015/12/04 14:23:27, flackr wrote:
> +oshima for trivial change in virtual keyboard controller test.

lgtm

[oshima, 2015-12-04 15:40:54]

lgtm

[flackr, 2015-12-04 15:57:38]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2015-12-04 15:58:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488303005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488303005/20001

[commit-bot: I haz the power, 2015-12-04 16:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 16:37:58]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[flackr, 2015-12-04 16:48:54]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2015-12-04 16:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488303005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488303005/20001

[commit-bot: I haz the power, 2015-12-04 17:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 17:17:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[flackr, 2015-12-04 20:23:18]

flackr@chromium.org changed reviewers:
+ isherman@chromium.org

[flackr, 2015-12-04 20:23:18]

isherman: Please review changes in tools/metrics/histograms/histograms.xml

iirc, we don't remove old values, correct?

[Ilya Sherman, 2015-12-05 02:47:58]

LGTM

On 2015/12/04 20:23:18, flackr wrote:
> isherman: Please review changes in tools/metrics/histograms/histograms.xml
> 
> iirc, we don't remove old values, correct?

Correctamundo.

[flackr, 2015-12-05 14:13:27]

The CQ bit was checked by flackr@chromium.org

[flackr, 2015-12-05 14:13:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rsadam@chromium.org,
oshima@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1488303005/#ps40001
(title: "Add new flags to histograms.")

[commit-bot: I haz the power, 2015-12-05 14:14:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488303005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488303005/40001

[commit-bot: I haz the power, 2015-12-05 16:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 16:16:01]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[flackr, 2015-12-07 14:27:01]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2015-12-07 14:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488303005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488303005/40001

[commit-bot: I haz the power, 2015-12-07 15:43:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-07 15:43:52]

Description was changed from

==========
Replace multi-value keyboard flags with single value flag types.

Use the new disable value flags to replace multi-value keyboard flags. This has
the property that the multi-value flag had (can change without a string update)
and makes it clear to the user which value is default.

BUG=245319
==========

to

==========
Replace multi-value keyboard flags with single value flag types.

Use the new disable value flags to replace multi-value keyboard flags. This has
the property that the multi-value flag had (can change without a string update)
and makes it clear to the user which value is default.

BUG=245319

Committed: https://crrev.com/512a1038bac66e0afae60e7431f88e39ccf3e120
Cr-Commit-Position: refs/heads/master@{#363484}
==========

[commit-bot: I haz the power, 2015-12-07 15:43:53]

Patchset 3 (id:??) landed as
https://crrev.com/512a1038bac66e0afae60e7431f88e39ccf3e120
Cr-Commit-Position: refs/heads/master@{#363484}