Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 14883003: cc: Fix impl-side painting flashing due to missing tiles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_image_layer_impl_unittest.cc ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 9da335db69911f446c0befa3a9fa255dde772e55..bf142a51346dc2f2914b046a1c127ddf982a737e 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -522,6 +522,13 @@ void PictureLayerImpl::SyncTiling(
if (!DrawsContent() || tiling->contents_scale() < MinimumContentsScale())
return;
tilings_->AddTiling(tiling->contents_scale());
+
+ // If this tree needs update draw properties, then the tiling will
+ // get updated prior to drawing or activation. If this tree does not
+ // need update draw properties, then its transforms are up to date and
+ // we can create tiles for this tiling immediately.
+ if (!layer_tree_impl()->needs_update_draw_properties())
+ UpdateTilePriorities();
}
void PictureLayerImpl::SetIsMask(bool is_mask) {
@@ -555,6 +562,7 @@ ResourceProvider::ResourceId PictureLayerImpl::ContentsResourceId() const {
bool PictureLayerImpl::AreVisibleResourcesReady() const {
DCHECK(layer_tree_impl()->IsPendingTree());
+ DCHECK(!layer_tree_impl()->needs_update_draw_properties());
DCHECK(ideal_contents_scale_);
if (!tilings_->num_tilings())
@@ -586,6 +594,7 @@ bool PictureLayerImpl::AreVisibleResourcesReady() const {
Region missing_region = rect;
for (size_t i = 0; i < tilings_->num_tilings(); ++i) {
PictureLayerTiling* tiling = tilings_->tiling_at(i);
+ DCHECK(tiling->has_ever_been_updated());
if (tiling->contents_scale() < min_acceptable_scale)
continue;
« no previous file with comments | « cc/layers/picture_image_layer_impl_unittest.cc ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698