Issue 1488273002: Fixes for exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1488273002: Fixes for exports (Closed)

Created:
5 years ago by vsm

Modified:
5 years ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixes for exports BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/14a5da5fde39b3ce1a2fe033c5bd82af31fb5007

Patch Set 1 #

Total comments: 1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	lib/runtime/dart/_utils.js	View		2 chunks	+7 lines, -2 lines	1 comment	Download
	M	tool/input_sdk/private/utils.dart	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/1488273002/diff/1/lib/runtime/dart/_utils.js File lib/runtime/dart/_utils.js (right): https://codereview.chromium.org/1488273002/diff/1/lib/runtime/dart/_utils.js#newcode84 lib/runtime/dart/_utils.js:84: if (show == void 0 || show.length == 0) ...

5 years ago (2015-12-01 22:29:51 UTC) #3

vsm

5 years ago (2015-12-01 23:55:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
14a5da5fde39b3ce1a2fe033c5bd82af31fb5007 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages