Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1488213002: Add in shader blending for CoverageSetOp XP (Closed)

Created:
5 years ago by egdaniel
Modified:
5 years ago
Reviewers:
bsalomon, ethannicholas
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add in shader blending for CoverageSetOp XP BUG=skia: Committed: https://skia.googlesource.com/skia/+/f34b293681ea49aaa4aaa70d84515e4a58a112e7

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -14 lines) Patch
M src/effects/SkArithmeticMode_gpu.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 2 chunks +91 lines, -0 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLBlend.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLBlend.cpp View 1 1 chunk +47 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.cpp View 1 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
egdaniel
This is needed for future pls draws
5 years ago (2015-12-01 20:03:15 UTC) #2
ethannicholas
On 2015/12/01 20:03:15, egdaniel wrote: > This is needed for future pls draws lgtm
5 years ago (2015-12-01 20:24:07 UTC) #3
bsalomon
lgtm
5 years ago (2015-12-01 20:34:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488213002/1
5 years ago (2015-12-01 20:37:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4543) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years ago (2015-12-01 20:41:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488213002/20001
5 years ago (2015-12-01 21:41:14 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 21:54:17 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f34b293681ea49aaa4aaa70d84515e4a58a112e7

Powered by Google App Engine
This is Rietveld 408576698