Issue 14882011: Pass bounds into draw calls in path renderers.

Issue 14882011: Pass bounds into draw calls in path renderers. (Closed)

Created:
7 years, 7 months ago by bsalomon

Modified:
7 years, 7 months ago

Reviewers:
jvanverth1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Pass bounds into draw calls in path renderers. R=jvanverth@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9171

Patch Set 1 #

Total comments: 4

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -11 lines)			Patch
M	src/gpu/GrAAConvexPathRenderer.cpp	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	src/gpu/GrDefaultPathRenderer.cpp	View	3 chunks	+6 lines, -7 lines	4 comments	Download
M	src/gpu/GrPathRenderer.h	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	src/gpu/GrPathRenderer.cpp	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 suggestion https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer.cpp File src/gpu/GrDefaultPathRenderer.cpp (right): https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer.cpp#newcode465 src/gpu/GrDefaultPathRenderer.cpp:465: // draw over the whole ...

7 years, 7 months ago (2013-05-16 13:14:45 UTC) #3

jvanverth1

lgtm https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer.cpp File src/gpu/GrDefaultPathRenderer.cpp (right): https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer.cpp#newcode465 src/gpu/GrDefaultPathRenderer.cpp:465: // draw over the whole world. Change this ...

7 years, 7 months ago (2013-05-16 13:20:03 UTC) #5

bsalomon

Committed patchset #1 manually as r9171 (presubmit successful).

7 years, 7 months ago (2013-05-16 19:59:06 UTC) #6

bsalomon

7 years, 7 months ago (2013-05-16 19:59:07 UTC) #7

Message was sent while issue was closed.

As for perf, I didn't take exact measurements but the demo at
http://codepen.io/anon/full/ripyt runs at 60fps instead of very slowly.

https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer...
File src/gpu/GrDefaultPathRenderer.cpp (right):

https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer...
src/gpu/GrDefaultPathRenderer.cpp:465: // draw over the whole world.
On 2013/05/16 13:20:04, JimVV wrote:
> Change this comment?

Done.

https://codereview.chromium.org/14882011/diff/1/src/gpu/GrDefaultPathRenderer...
src/gpu/GrDefaultPathRenderer.cpp:465: // draw over the whole world.
On 2013/05/16 13:14:45, robertphillips wrote:
> // GetPathDevBounds sets the bound to the device's full size for inverse
filled
> paths

Done.

Expand Messages | Collapse Messages