Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 14882009: Remove DOM prefix from several IDL interfaces (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, webcomponents-bugzilla_chromium.org, eae+blinkwatch, abarth-chromium, kinuko, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Nate Chapin, mkwst+watchlist_chromium.org, lgombos
Visibility:
Public.

Description

Remove DOM prefix from several IDL interfaces Remove DOM prefix from several IDL interfaces and use [ImplementedAs] extended attribute instead of [InterfaceName] for those. Also stop using [InterfaceName] in bindings tests. [InterfaceName] is deprecated and we should progressively stop using it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150351

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix DOMExceptions generator #

Patch Set 3 : No longer rename DOMCoreException.idl #

Patch Set 4 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -5709 lines) Patch
M Source/bindings/bindings.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/TestCallback.idl View 1 chunk +4 lines, -4 lines 0 comments Download
D Source/bindings/tests/idls/TestObj.idl View 1 2 3 1 chunk +0 lines, -307 lines 0 comments Download
A + Source/bindings/tests/idls/TestObject.idl View 1 2 3 8 chunks +29 lines, -29 lines 0 comments Download
M Source/bindings/tests/idls/TestPartialInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallback.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/tests/results/V8TestObj.h View 1 2 3 1 chunk +0 lines, -146 lines 0 comments Download
D Source/bindings/tests/results/V8TestObj.cpp View 1 2 3 1 chunk +0 lines, -4516 lines 0 comments Download
A + Source/bindings/tests/results/V8TestObject.h View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
A + Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 264 chunks +319 lines, -321 lines 0 comments Download
D Source/bindings/v8/custom/V8DOMFormDataCustom.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
A + Source/bindings/v8/custom/V8FormDataCustom.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 6 chunks +5 lines, -5 lines 0 comments Download
A + Source/core/css/CSS.idl View 1 chunk +2 lines, -4 lines 0 comments Download
D Source/core/css/DOMWindowCSS.idl View 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/dom/Document.idl View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/html/DOMFormData.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/html/DOMURL.idl View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/html/FormData.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/URL.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/page/DOMSecurityPolicy.idl View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/page/DOMSelection.idl View 1 chunk +0 lines, -86 lines 0 comments Download
M Source/core/page/DOMWindow.idl View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/page/SecurityPolicy.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/page/Selection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/scripts/name_macros.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerContext.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-13 13:42:13 UTC) #1
haraken
LGTM https://codereview.chromium.org/14882009/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm File Source/bindings/scripts/CodeGeneratorV8.pm (right): https://codereview.chromium.org/14882009/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm#newcode2391 Source/bindings/scripts/CodeGeneratorV8.pm:2391: my $multiLine = ($functionCall =~ tr/\n//) > 1; ...
7 years, 7 months ago (2013-05-13 13:53:27 UTC) #2
do-not-use
On 2013/05/13 13:53:27, haraken wrote: > LGTM > > https://codereview.chromium.org/14882009/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm > File Source/bindings/scripts/CodeGeneratorV8.pm (right): > ...
7 years, 7 months ago (2013-05-13 13:55:16 UTC) #3
haraken
ok, then let's keep your patch as is :)
7 years, 7 months ago (2013-05-13 14:05:44 UTC) #4
do-not-use
On 2013/05/13 14:05:44, haraken wrote: > ok, then let's keep your patch as is :) ...
7 years, 7 months ago (2013-05-13 14:11:06 UTC) #5
arv (Not doing code reviews)
LGTM
7 years, 7 months ago (2013-05-13 14:47:07 UTC) #6
do-not-use
Could someone please review the changes to: Source/core/dom/DOMExceptions.in Source/core/scripts/make_dom_exceptions.py Source/core/scripts/name_macros.py I fixed the build but ...
7 years, 7 months ago (2013-05-13 21:15:56 UTC) #7
abarth-chromium
I'm not sure the change to the "in" file is exactly what we want to ...
7 years, 7 months ago (2013-05-13 22:33:42 UTC) #8
Chris Dumez
On 2013/05/13 22:33:42, abarth wrote: > I'm not sure the change to the "in" file ...
7 years, 7 months ago (2013-05-14 06:21:26 UTC) #9
do-not-use
On 2013/05/14 06:21:26, dchris wrote: > On 2013/05/13 22:33:42, abarth wrote: > > I'm not ...
7 years, 7 months ago (2013-05-14 08:48:53 UTC) #10
haraken
LGTM.
7 years, 7 months ago (2013-05-14 12:57:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14882009/19001
7 years, 7 months ago (2013-05-14 13:20:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14882009/19001
7 years, 7 months ago (2013-05-14 18:26:58 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 20:35:15 UTC) #14
Message was sent while issue was closed.
Change committed as 150351

Powered by Google App Engine
This is Rietveld 408576698