Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 14882004: Revert 198834 "Add chrome_split_dll gyp variable, and duplicate ..." (Closed)

Created:
7 years, 7 months ago by dewittj
Modified:
7 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198834 "Add chrome_split_dll gyp variable, and duplicate ..." > Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target > > Currently contains chrome_browser_dll target. Removes some paths from browser->webcore > via content that are there due to single process mode, and removes dependency of content > on content_renderer. > > Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg > > R=cpu@chromium.org > BUG=237249 > > Review URL: https://chromiumcodereview.appspot.com/14682014 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -220 lines) Patch
M trunk/src/build/common.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/app/chrome_main_delegate.cc View 3 chunks +1 line, -24 lines 0 comments Download
M trunk/src/chrome/chrome.gyp View 3 chunks +3 lines, -13 lines 0 comments Download
M trunk/src/chrome/chrome_dll.gypi View 5 chunks +71 lines, -130 lines 0 comments Download
M trunk/src/chrome/chrome_exe.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/test/gpu/test_support_gpu.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/app/content_main_runner.cc View 4 chunks +2 lines, -20 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/content.gyp View 2 chunks +2 lines, -7 lines 0 comments Download
M trunk/src/content/public/app/content_main_delegate.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dewittj
7 years, 7 months ago (2013-05-08 00:42:59 UTC) #1
dewittj
Committed patchset #1 manually as r198837.
7 years, 7 months ago (2013-05-08 00:43:16 UTC) #2
dewittj
Google chrome win builder's error: 618>------ Build started: Project: cloud_print_service_setup, Configuration: Release Win32 ------ 616>Link: ...
7 years, 7 months ago (2013-05-08 00:45:28 UTC) #3
dewittj
Mac builder's error: Updating projects from gyp files... gyp: Dependency '/Volumes/data/b/build/slave/cr-mac-rel/build/src/chrome/chrome.gyp:chrome_dll_pdb_workaround#target' not found while trying ...
7 years, 7 months ago (2013-05-08 00:46:03 UTC) #4
scottmg
7 years, 7 months ago (2013-05-08 02:46:45 UTC) #5
Message was sent while issue was closed.
Sorry, thanks for reverting.

(I hit the CQ button assuming it'd kick off the tryjobs, but for some reason it
just got directly committed.)

Powered by Google App Engine
This is Rietveld 408576698