Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1488123003: Clean up some PNG assets. (Closed)

Created:
5 years ago by Evan Stade
Modified:
5 years ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some PNG assets. - move platform-specific icons out of common/ - remove unused assets - add some relevant <if expr> guards BUG=522168 Committed: https://crrev.com/7f28de65921407429eff8ebd78db38c3b1b56710 Cr-Commit-Position: refs/heads/master@{#363288}

Patch Set 1 #

Patch Set 2 : git add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
D chrome/app/theme/default_100_percent/common/discard_wide.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/downloads/cancel.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/downloads/delete.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/downloads/download.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/downloads/folder.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/downloads/pause.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/notification_tray_attention.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/notification_tray_do_not_disturb_attention.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/notification_tray_do_not_disturb_empty.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/notification_tray_empty.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/snapshot_wide.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/discard_wide.png View 1 Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/downloads/cancel.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/downloads/delete.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/downloads/download.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/downloads/folder.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/downloads/pause.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/snapshot_wide.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/discard_wide.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/downloads/cancel.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/downloads/delete.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/downloads/download.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/downloads/folder.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/downloads/pause.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/notification_tray_attention.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/notification_tray_do_not_disturb_attention.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/notification_tray_do_not_disturb_empty.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/notification_tray_empty.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/snapshot_wide.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/discard_wide.png View 1 Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/downloads/cancel.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/downloads/delete.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/downloads/download.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/downloads/folder.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/downloads/pause.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/snapshot_wide.png View 1 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 6 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488123003/1
5 years ago (2015-12-01 22:42:54 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/37006) win8_chromium_ng on ...
5 years ago (2015-12-01 22:56:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488123003/20001
5 years ago (2015-12-02 00:44:25 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 02:24:46 UTC) #10
Evan Stade
ping
5 years ago (2015-12-04 16:07:30 UTC) #11
oshima
lgtm
5 years ago (2015-12-04 17:50:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488123003/20001
5 years ago (2015-12-04 19:43:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-04 20:55:08 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-04 20:55:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f28de65921407429eff8ebd78db38c3b1b56710
Cr-Commit-Position: refs/heads/master@{#363288}

Powered by Google App Engine
This is Rietveld 408576698