Issue 14881002: build fix for 14530

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14881002: build fix for 14530 (Closed)

Created:
7 years, 7 months ago by dcarney

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
	M	test/cctest/test-global-object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/cctest/test-object-observe.cc	View		13 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

I verified that on windows, it fails to build locally without this patch, and builds ...

7 years, 7 months ago (2013-05-02 21:53:41 UTC) #1

dcarney

Committed patchset #1 manually as r14532 (presubmit successful).

7 years, 7 months ago (2013-05-02 22:00:48 UTC) #2

Message was sent while issue was closed.

lgtm