Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 1488063002: Revert of [heap] Remove eager shortcut in JSFunction visitor. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove eager shortcut in JSFunction visitor. (patchset #1 id:1 of https://codereview.chromium.org/1476223002/ ) Reason for revert: Still investigating bad canary. Original issue's description: > [heap] Remove eager shortcut in JSFunction visitor. > > This removes an optimization in the static JSFunction visitor that > eagerly marked through to the SharedFunctionInfo for code flushing > candidates. This causes all processing in VisitJSFunction to be > side-stepped and hence might cause leaks. > > R=hpayer@chromium.org > > Committed: https://crrev.com/a29f0576c32e8fda90bf7ab19c6d170568150a7f > Cr-Commit-Position: refs/heads/master@{#32332} TBR=mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/672b49119b857c4f96234b03e48b4b60de256969 Cr-Commit-Position: refs/heads/master@{#32463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Hannes Payer (out of office)
Created Revert of [heap] Remove eager shortcut in JSFunction visitor.
5 years ago (2015-12-01 13:30:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488063002/1
5 years ago (2015-12-01 13:30:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488063002/1
5 years ago (2015-12-01 13:32:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 13:32:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/672b49119b857c4f96234b03e48b4b60de256969 Cr-Commit-Position: refs/heads/master@{#32463}
5 years ago (2015-12-01 13:33:00 UTC) #6
Hannes Payer (out of office)
5 years ago (2015-12-03 12:22:27 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1486413006/ by hpayer@chromium.org.

The reason for reverting is: Suspect for crashing found, relanding for canary
coverage..

Powered by Google App Engine
This is Rietveld 408576698