src/parsing/preparser.h - Issue 1488043002: [parser] treat MethodDefinitions in ObjectPatterns as SyntaxErrors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/preparser.h

Issue 1488043002: [parser] treat MethodDefinitions in ObjectPatterns as SyntaxErrors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parsing/preparser.h

diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h

index e93f3f998dc27687069e47412b6db94f8de4c46c..d35c439619b2e8722728a1950a2c11315a9af10d 100644

--- a/src/parsing/preparser.h

+++ b/src/parsing/preparser.h

@@ -2737,6 +2737,8 @@ ParserBase<Traits>::ParsePropertyDefinition(

return this->EmptyObjectLiteralProperty();

}

+ BindingPatternUnexpectedToken(classifier);

if (is_generator || peek() == Token::LPAREN) {

// MethodDefinition

// PropertyName '(' StrictFormalParameters ')' '{' FunctionBody '}'

« no previous file with comments | « no previous file | test/mjsunit/harmony/regress/regress-4585.js » ('j') | test/mjsunit/harmony/regress/regress-4585.js » ('J')