Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: media/base/audio_renderer_sink.h

Issue 1487983002: Forward the number of skipped frames by the OS in audio playout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Writing skipped frames to shared memory. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_renderer_sink.h
diff --git a/media/base/audio_renderer_sink.h b/media/base/audio_renderer_sink.h
index 30cbfef5ae3b82b27375346d90b47f5b5c4ef577..b45c0fc9ed6a47b9bb80210ec26c7242e538bedc 100644
--- a/media/base/audio_renderer_sink.h
+++ b/media/base/audio_renderer_sink.h
@@ -35,8 +35,11 @@ class AudioRendererSink
class RenderCallback {
public:
// Attempts to completely fill all channels of |dest|, returns actual
- // number of frames filled.
- virtual int Render(AudioBus* dest, int audio_delay_milliseconds) = 0;
+ // number of frames filled. |frames_skipped| contains the number of frames
+ // the consumer has skipped, if any.
tommi (sloooow) - chröme 2015/12/08 08:34:51 Since it's the OS that is skipping these frames an
Henrik Grunell 2015/12/08 09:30:34 Yep, it's confusing. Refers to consumer of the aud
+ virtual int Render(AudioBus* dest,
+ uint32_t audio_delay_milliseconds,
+ uint32_t frames_skipped) = 0;
// Signals an error has occurred.
virtual void OnRenderError() = 0;

Powered by Google App Engine
This is Rietveld 408576698