Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1487973002: [turbofan] Add binary operation hints for javascript operators. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add binary operation hints for javascript operators. This is the initial support for binary operation hints on javascript binary operators, i.e. JSAdd, JSSubtract and so on. The hints are extracted from the fullcodegen code object before graph building and the AstGraphBuilder puts those hints on the operators if available. R=jarin@chromium.org BUG=v8:4583 LOG=n Committed: https://crrev.com/5af6017d4b5fccc7d26946ff6fca03057b78eab8 Cr-Commit-Position: refs/heads/master@{#32443}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -206 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 4 chunks +12 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 7 chunks +30 lines, -17 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +23 lines, -11 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/compiler/js-operator.h View 3 chunks +50 lines, -11 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +177 lines, -16 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +10 lines, -1 line 1 comment Download
M src/compiler/pipeline.cc View 8 chunks +29 lines, -2 lines 0 comments Download
A src/compiler/type-hint-analyzer.h View 1 chunk +54 lines, -0 lines 0 comments Download
A src/compiler/type-hint-analyzer.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A src/compiler/type-hints.h View 1 chunk +58 lines, -0 lines 0 comments Download
A src/compiler/type-hints.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/ic/ic-state.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ic-state.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M src/type-info.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 9 chunks +46 lines, -32 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 11 chunks +27 lines, -19 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 3 chunks +64 lines, -52 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
5 years ago (2015-12-01 06:42:02 UTC) #1
Jarin
Awesome. LGTM. https://codereview.chromium.org/1487973002/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1487973002/diff/1/src/compiler/js-typed-lowering.cc#newcode221 src/compiler/js-typed-lowering.cc:221: // TODO(turbofan): Strong mode should be killed ...
5 years ago (2015-12-01 07:31:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487973002/1
5 years ago (2015-12-01 08:53:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 09:03:15 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 09:03:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5af6017d4b5fccc7d26946ff6fca03057b78eab8
Cr-Commit-Position: refs/heads/master@{#32443}

Powered by Google App Engine
This is Rietveld 408576698