Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: pkg/analyzer/test/generated/resolver_test.dart

Issue 1487953002: Clean-up the registration of plugins (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/engine_test.dart ('k') | pkg/analyzer/test/generated/test_support.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/resolver_test.dart
diff --git a/pkg/analyzer/test/generated/resolver_test.dart b/pkg/analyzer/test/generated/resolver_test.dart
index bc05806f4d945c548aff1cfa9b9ef4b722bf2522..a7fbb3084c6262cce77689dcc139924b2d897139 100644
--- a/pkg/analyzer/test/generated/resolver_test.dart
+++ b/pkg/analyzer/test/generated/resolver_test.dart
@@ -1302,6 +1302,7 @@ class ElementResolverTest extends EngineTestCase {
@override
void setUp() {
+ super.setUp();
_listener = new GatheringErrorListener();
_typeProvider = new TestTypeProvider();
_resolver = _createResolver();
@@ -4840,7 +4841,7 @@ class A {
}
@reflectiveTest
-class InheritanceManagerTest extends EngineTestCase {
+class InheritanceManagerTest {
/**
* The type provider used to access the types.
*/
@@ -4861,7 +4862,6 @@ class InheritanceManagerTest extends EngineTestCase {
*/
int _numOfMembersInObject = 0;
- @override
void setUp() {
_typeProvider = new TestTypeProvider();
_inheritanceManager = _createInheritanceManager();
@@ -6065,7 +6065,7 @@ class InheritanceManagerTest extends EngineTestCase {
}
@reflectiveTest
-class LibraryElementBuilderTest extends EngineTestCase {
+class LibraryElementBuilderTest {
/**
* The analysis context used to analyze sources.
*/
@@ -6084,15 +6084,12 @@ class LibraryElementBuilderTest extends EngineTestCase {
return source;
}
- @override
void setUp() {
_context = AnalysisContextFactory.contextWithCore();
}
- @override
void tearDown() {
_context = null;
- super.tearDown();
}
void test_accessorsAcrossFiles() {
@@ -6590,7 +6587,7 @@ class LibraryScopeTest extends ResolverTestCase {
}
@reflectiveTest
-class LibraryTest extends EngineTestCase {
+class LibraryTest {
/**
* The error listener to which all errors will be reported.
*/
@@ -6606,19 +6603,16 @@ class LibraryTest extends EngineTestCase {
*/
Library _library;
- @override
void setUp() {
_analysisContext = AnalysisContextFactory.contextWithCore();
_errorListener = new GatheringErrorListener();
_library = _createLibrary("/lib.dart");
}
- @override
void tearDown() {
_errorListener = null;
_analysisContext = null;
_library = null;
- super.tearDown();
}
void test_getExplicitlyImportsCore() {
@@ -8426,6 +8420,7 @@ class ResolverTestCase extends EngineTestCase {
@override
void setUp() {
+ super.setUp();
reset();
}
@@ -10362,6 +10357,7 @@ class StaticTypeAnalyzerTest extends EngineTestCase {
@override
void setUp() {
+ super.setUp();
_listener = new GatheringErrorListener();
_typeProvider = new TestTypeProvider();
_analyzer = _createAnalyzer();
@@ -12679,7 +12675,7 @@ int x = 3;
}
@reflectiveTest
-class SubtypeManagerTest extends EngineTestCase {
+class SubtypeManagerTest {
/**
* The inheritance manager being tested.
*/
@@ -12690,9 +12686,7 @@ class SubtypeManagerTest extends EngineTestCase {
*/
CompilationUnitElementImpl _definingCompilationUnit;
- @override
void setUp() {
- super.setUp();
AnalysisContext context = AnalysisContextFactory.contextWithCore();
FileBasedSource source =
new FileBasedSource(FileUtilities2.createFile("/test.dart"));
@@ -14578,7 +14572,7 @@ class TypeProviderImplTest extends EngineTestCase {
}
@reflectiveTest
-class TypeResolverVisitorTest extends EngineTestCase {
+class TypeResolverVisitorTest {
/**
* The error listener to which errors will be reported.
*/
@@ -14620,7 +14614,6 @@ class TypeResolverVisitorTest extends EngineTestCase {
_listener.assertNoErrors();
}
- @override
void setUp() {
_listener = new GatheringErrorListener();
InternalAnalysisContext context = AnalysisContextFactory.contextWithCore();
« no previous file with comments | « pkg/analyzer/test/generated/engine_test.dart ('k') | pkg/analyzer/test/generated/test_support.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698