Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1487953002: Clean-up the registration of plugins (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -146 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +16 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +13 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 4 chunks +52 lines, -45 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +16 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 2 chunks +19 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +13 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +18 lines, -35 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 5 chunks +7 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 13 chunks +8 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +14 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/inputs_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Reworked based on your earlier comments and slated for inclusion in the breaking changes branch.
5 years ago (2015-12-01 04:11:43 UTC) #2
scheglov
LGTM
5 years ago (2015-12-01 04:35:57 UTC) #3
Brian Wilkerson
5 years ago (2015-12-02 21:25:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
600fc17de1f7af03139b82e966ee14188f194eca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698