Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1487933002: SiteDetails: use the Origin instead of the URL. (Closed)

Created:
5 years ago by ncarter (slow)
Modified:
5 years ago
Reviewers:
jam, nasko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SiteDetails: use the Origin instead of the URL. This lets us more correctly identify the site, in particular for window.open/about:blank, and blob URLs. BUG=498580 TEST=SiteDetailsBrowserTest Committed: https://crrev.com/abbb4dcbda184a18a9979fc7962df7bf5bcac5cc Cr-Commit-Position: refs/heads/master@{#363048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/site_details.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ncarter (slow)
5 years ago (2015-11-30 23:26:57 UTC) #2
nasko
Thanks for fixing this! LGTM
5 years ago (2015-11-30 23:37:05 UTC) #3
ncarter (slow)
+jam, for chrome/ OWNERS
5 years ago (2015-12-01 17:55:39 UTC) #6
jam
lgtm
5 years ago (2015-12-01 23:38:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487933002/1
5 years ago (2015-12-03 19:50:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 20:38:41 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 20:40:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abbb4dcbda184a18a9979fc7962df7bf5bcac5cc
Cr-Commit-Position: refs/heads/master@{#363048}

Powered by Google App Engine
This is Rietveld 408576698