Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148793003: fix script so that the error is actually printed if ant is not installed (Closed)

Created:
6 years, 10 months ago by djsollen
Modified:
6 years, 10 months ago
Reviewers:
scroggo, hcm
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

fix script so that the error is actually printed if ant is not installed Committed: http://code.google.com/p/skia/source/detail?r=13290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/bin/android_setup.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
djsollen
6 years, 10 months ago (2014-02-03 20:23:10 UTC) #1
hcm
On 2014/02/03 20:23:10, djsollen wrote: LGTM, bug I opened while you were already done fixing ...
6 years, 10 months ago (2014-02-03 20:30:53 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 10 months ago (2014-02-03 20:33:36 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 20:33:38 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-03 20:33:39 UTC) #5
scroggo
On 2014/02/03 20:33:39, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 10 months ago (2014-02-03 20:35:14 UTC) #6
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 10 months ago (2014-02-03 20:37:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/148793003/1
6 years, 10 months ago (2014-02-03 20:37:12 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 21:20:12 UTC) #9
commit-bot: I haz the power
Change committed as 13290
6 years, 10 months ago (2014-02-03 21:20:14 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 21:20:29 UTC) #11
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698