Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1487903002: Issue 25048. Ignore inner analysis roots which are already managed by outer roots. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 25048. Ignore inner analysis roots which are already managed by outer roots. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/25048 Committed: https://github.com/dart-lang/sdk/commit/5b2ad27b06940ee1005630d431f7b89db5241b38

Patch Set 1 #

Total comments: 1

Patch Set 2 : Additional test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -74 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 12 chunks +74 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 3 chunks +197 lines, -45 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-11-30 22:39:14 UTC) #1
Brian Wilkerson
LGTM, with or without the extra test https://codereview.chromium.org/1487903002/diff/1/pkg/analysis_server/test/context_manager_test.dart File pkg/analysis_server/test/context_manager_test.dart (right): https://codereview.chromium.org/1487903002/diff/1/pkg/analysis_server/test/context_manager_test.dart#newcode1146 pkg/analysis_server/test/context_manager_test.dart:1146: void test_setRoots_nested_excludedByOuter() ...
5 years ago (2015-11-30 22:52:22 UTC) #2
scheglov
5 years ago (2015-11-30 23:01:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5b2ad27b06940ee1005630d431f7b89db5241b38 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698