Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 148783005: Extract XcodeVersion to be a standalone module function (Closed)

Created:
6 years, 10 months ago by sdefresne
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai, Nico
CC:
gyp-developer_googlegroups.com, justincohen
Visibility:
Public.

Description

Extract XcodeVersion to be a standalone module function The _XcodeVersion from XcodeSettings class does not need to be a member function as it does not use any of the field of the class. Extract it to be a standalone function at the module level, and all the functions it calls (that also don't use fields from XcodeSettings). Keep the _XcodeVersion wrapper function that keeps a cache of the values returned from Xcode to not degrade performance for clients of the old API that may depends on that cache. BUG=None R=mark@chromium.org, thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -65 lines) Patch
M pylib/gyp/xcode_emulation.py View 4 chunks +75 lines, -65 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sdefresne
In my issue 138533006 (https://codereview.chromium.org/138533006/) I needed to use XcodeVersion without having an XcodeSettings object ...
6 years, 10 months ago (2014-02-11 10:38:40 UTC) #1
sdefresne
+cc: justincohen
6 years, 10 months ago (2014-02-11 10:39:11 UTC) #2
Mark Mentovai
LGTM
6 years, 10 months ago (2014-02-11 14:10:44 UTC) #3
sdefresne
6 years, 10 months ago (2014-02-11 16:15:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698