Avoid race-warning for access to animatableAttributes

Avoid race-warning for access to animatableAttributes

Collecting debug data during a commit in CC can land us in this method
while not running in the main thread  (although it'll be blocked).
Since this is assert-only code, switch to a thread-safe initializer to
avoid triggering this warning. Hopefully this doesn't slow things down
to badly on bots.

BUG=545972
Committed: https://crrev.com/56c43a002072a04abe25a77f400a1e3425ab8991
Cr-Commit-Position: refs/heads/master@{#363687}

[fs, 2015-11-30 20:25:34]

Description was changed from

==========
Avoid race-warning for access to animatableAttributes

Collecting debug data during a commit in CC can land us in this method
while not running in the main thread  (although it'll be blocked).
Since this is assert-only code, switch to thread-safe initializer to
avoid triggering this warning. Hopefully this doesn't slow things down
to badly on bots.

BUG=545972
==========

to

==========
Avoid race-warning for access to animatableAttributes

Collecting debug data during a commit in CC can land us in this method
while not running in the main thread  (although it'll be blocked).
Since this is assert-only code, switch to a thread-safe initializer to
avoid triggering this warning. Hopefully this doesn't slow things down
to badly on bots.

BUG=545972
==========

[pdr., 2015-12-07 20:57:45]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[pdr., 2015-12-07 20:57:46]

Why don't other define_static_locals have issues? They are all over the blink
codebase.

[fs, 2015-12-07 21:27:52]

On 2015/12/07 at 20:57:46, pdr wrote:
> Why don't other define_static_locals have issues? They are all over the blink
codebase.

Because they are not unfortunate enough to be used by the *::debugName()
code-path (which is called from a different thread). Not that I would want to
rule that out completely though...

[pdr., 2015-12-07 21:28:55]

On 2015/12/07 at 21:27:52, fs wrote:
> On 2015/12/07 at 20:57:46, pdr wrote:
> > Why don't other define_static_locals have issues? They are all over the
blink codebase.
> 
> Because they are not unfortunate enough to be used by the *::debugName()
code-path (which is called from a different thread). Not that I would want to
rule that out completely though...

I see. LGTM then

[fs, 2015-12-07 21:29:40]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-12-07 21:31:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487813002/40001

[commit-bot: I haz the power, 2015-12-08 01:26:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-08 01:27:53]

Description was changed from

==========
Avoid race-warning for access to animatableAttributes

Collecting debug data during a commit in CC can land us in this method
while not running in the main thread  (although it'll be blocked).
Since this is assert-only code, switch to a thread-safe initializer to
avoid triggering this warning. Hopefully this doesn't slow things down
to badly on bots.

BUG=545972
==========

to

==========
Avoid race-warning for access to animatableAttributes

Collecting debug data during a commit in CC can land us in this method
while not running in the main thread  (although it'll be blocked).
Since this is assert-only code, switch to a thread-safe initializer to
avoid triggering this warning. Hopefully this doesn't slow things down
to badly on bots.

BUG=545972

Committed: https://crrev.com/56c43a002072a04abe25a77f400a1e3425ab8991
Cr-Commit-Position: refs/heads/master@{#363687}
==========

[commit-bot: I haz the power, 2015-12-08 01:27:55]

Patchset 3 (id:??) landed as
https://crrev.com/56c43a002072a04abe25a77f400a1e3425ab8991
Cr-Commit-Position: refs/heads/master@{#363687}