Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: json_reporter.schema.json

Issue 1487753003: Fix a couple bugs in the JSON schema. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Have the schema verify the protocol version. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: json_reporter.schema.json
diff --git a/json_reporter.schema.json b/json_reporter.schema.json
index cf932448927facf80d3f67570221df6f87c7db8f..946e8e687ad3c82205a2228947622981bb8d1338 100644
--- a/json_reporter.schema.json
+++ b/json_reporter.schema.json
@@ -4,10 +4,14 @@
"definitions": {
"Test": {
- "required": ["id", "name", "metadata"],
+ "required": ["id", "name", "groupIDs", "metadata"],
"properties": {
"id": {"type": "integer", "minimum": 0},
"name": {"type": "string"},
+ "groupIDs": {
+ "type": "array",
+ "items": {"type": "integer", "minimum": 0}
+ },
"metadata": {"$ref": "#/definitions/Metadata"}
}
},
@@ -49,7 +53,7 @@
"required": ["protocolVersion", "runnerVersion"],
"properties": {
"type": {"enum": ["start"]},
- "protocolVersion": {"type": "string"},
+ "protocolVersion": {"type": "string", "pattern": "^0\.1\."},
"runnerVersion": {
"oneOf": [{"type": "string"}, {"type": "null"}]
}
@@ -76,9 +80,10 @@
{
"title": "PrintEvent",
- "required": ["message"],
+ "required": ["testID", "message"],
"properties": {
"type": {"enum": ["print"]},
+ "testID": {"type": "integer", "minimum": 0},
"message": {"type": "string"}
}
},
@@ -117,6 +122,8 @@
{
"title": "FutureEvent",
+ "description":
+ "A placeholder event to allow new events to be added in the future.",
"properties": {
"type": {
"not": {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698