Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 1487743002: [heap] Remove ability to turn off code flushing on demand. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove ability to turn off code flushing on demand. This moves the decision whether code flushing is active into the setup phase of the GC. Components are no longer allowed to dynamically switch the code flushing mode on demand. R=hpayer@chromium.org Committed: https://crrev.com/54469cbb2fef1e2b96f652e6cdf89620ea4053cf Cr-Commit-Position: refs/heads/master@{#32446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -65 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/mark-compact.h View 3 chunks +0 lines, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 6 chunks +9 lines, -52 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-11-30 18:14:43 UTC) #1
Hannes Payer (out of office)
lgtm
5 years ago (2015-12-01 09:24:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487743002/1
5 years ago (2015-12-01 09:49:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 09:59:36 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 09:59:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54469cbb2fef1e2b96f652e6cdf89620ea4053cf
Cr-Commit-Position: refs/heads/master@{#32446}

Powered by Google App Engine
This is Rietveld 408576698