Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1487733003: Allow multiple OnMoreData() calls in WASAPIAudioOutputStreamTest.ValidPacketSize (Closed)

Created:
5 years ago by wdzierzanowski
Modified:
5 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow multiple OnMoreData() calls in WASAPIAudioOutputStreamTest.ValidPacketSize Follow up on https://codereview.chromium.org/1318933003/ and allow OnMoreData() to be called more than once in the test. BUG=524947 TEST=WASAPIAudioOutputStreamTest.ValidPacketSize passes Committed: https://crrev.com/7a7643ee8652ddab8503c57fe0ff1af174ea235b Cr-Commit-Position: refs/heads/master@{#362439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Let there be just one quit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
wdzierzanowski
PTAL
5 years ago (2015-12-01 08:34:07 UTC) #3
tommi (sloooow) - chröme
lgtm. I'll leave it up to you if you want to make the below change. ...
5 years ago (2015-12-01 10:06:54 UTC) #4
wdzierzanowski
https://codereview.chromium.org/1487733003/diff/1/media/audio/win/audio_low_latency_output_win_unittest.cc File media/audio/win/audio_low_latency_output_win_unittest.cc (right): https://codereview.chromium.org/1487733003/diff/1/media/audio/win/audio_low_latency_output_win_unittest.cc#newcode385 media/audio/win/audio_low_latency_output_win_unittest.cc:385: .WillRepeatedly(DoAll(QuitLoop(loop.task_runner()), On 2015/12/01 10:06:54, tommi wrote: > nit: You ...
5 years ago (2015-12-01 16:42:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487733003/20001
5 years ago (2015-12-01 16:56:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 17:10:32 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 17:11:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a7643ee8652ddab8503c57fe0ff1af174ea235b
Cr-Commit-Position: refs/heads/master@{#362439}

Powered by Google App Engine
This is Rietveld 408576698