Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1487723002: [Cronet] Replace setExperimentalQuicConnectionOptions with a more general API (Closed)

Created:
5 years ago by xunjieli
Modified:
5 years ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Cronet] Replace setExperimentalQuicConnectionOptions with a more general API This CL replaces CronetEngine.Builder#setExperimentalQuicConnectionOptions with a more general API to set experimental options. BUG=545118 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1414053008 Cr-Commit-Position: refs/heads/master@{#360187} (cherry picked from commit 61b1eaaab7d5f38c76a3fd41d23a737fe177d211)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -14 lines) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +4 lines, -6 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 2 chunks +7 lines, -1 line 0 comments Download
M components/cronet/url_request_context_config.h View 1 chunk +7 lines, -2 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 4 chunks +44 lines, -4 lines 0 comments Download
M components/cronet/url_request_context_config_list.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
xunjieli
PTAL
5 years ago (2015-11-30 17:33:27 UTC) #2
xunjieli
On 2015/11/30 17:33:27, xunjieli wrote: > PTAL This one needs to be merged first. I ...
5 years ago (2015-11-30 17:34:03 UTC) #3
mef
lgtm
5 years ago (2015-11-30 18:05:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487723002/1
5 years ago (2015-11-30 18:06:29 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years ago (2015-11-30 18:06:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487723002/1
5 years ago (2015-11-30 18:16:05 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-30 18:19:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698