Issue 14877010: DevTools: DOMStorage undo/redo feature

Issue 14877010: DevTools: DOMStorage undo/redo feature (Closed)

Created:
7 years, 7 months ago by vivekg__

Modified:
7 years, 4 months ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

DevTools: DOMStorage undo/redo feature BUG=

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+471 lines, -6 lines)			Patch
A	LayoutTests/inspector/storage-panel-dom-storage-undo-redo.html	View	1 chunk	+227 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector/storage-panel-dom-storage-undo-redo-expected.txt	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMStorageAgent.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMStorageAgent.cpp	View	1 chunk	+13 lines, -0 lines	1 comment	Download
M	Source/devtools/front_end/DOMStorage.js	View	2 chunks	+142 lines, -6 lines	1 comment	Download
M	Source/devtools/front_end/DOMStorageItemsView.js	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ResourcesPanel.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apavlov

https://codereview.chromium.org/14877010/diff/1/Source/core/inspector/InspectorDOMStorageAgent.cpp File Source/core/inspector/InspectorDOMStorageAgent.cpp (right): https://codereview.chromium.org/14877010/diff/1/Source/core/inspector/InspectorDOMStorageAgent.cpp#newcode126 Source/core/inspector/InspectorDOMStorageAgent.cpp:126: return; This doesn't make much sense, does it? https://codereview.chromium.org/14877010/diff/1/Source/devtools/front_end/DOMStorage.js ...

7 years, 7 months ago (2013-05-08 11:41:36 UTC) #1

pfeldman

> I would defer the decision on this to pfeldman, but IMHO the lightness of ...

7 years, 6 months ago (2013-05-29 16:00:38 UTC) #2

vivekg__

7 years, 4 months ago (2013-07-31 13:03:42 UTC) #3

Created a new issue https://codereview.chromium.org/21163003/ for the same.
Closing this issue.

Expand Messages | Collapse Messages