Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4953)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 1487693002: Upstrem prefs changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reviews Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prefs/incognito_mode_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index ee136d2b1e606bc518e261d6bf98394761d5b77d..06793a5f425b59c03c296e1b6a2ea6006f971e65 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -116,10 +116,8 @@
#include "chrome/browser/signin/easy_unlock_service.h"
#include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
#include "extensions/browser/extension_prefs.h"
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
#include "chrome/browser/extensions/api/copresence/copresence_api.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
-#endif
#endif // defined(ENABLE_EXTENSIONS)
#if defined(ENABLE_PLUGIN_INSTALLATION)
@@ -298,10 +296,18 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
TaskManager::RegisterPrefs(registry);
#endif // defined(ENABLE_TASK_MANAGER)
-#if !defined(OS_ANDROID)
+#if defined(ENABLE_BACKGROUND)
BackgroundModeManager::RegisterPrefs(registry);
- ChromeTracingDelegate::RegisterPrefs(registry);
+#endif
+
+ // TODO(bshe): Use !defined(ANDROID_JAVA_UI) once
+ // codereview.chromium.org/1459793002 landed.
+#if !defined(OS_ANDROID) || defined(USE_AURA)
RegisterBrowserPrefs(registry);
+#endif
+
+#if !defined(OS_ANDROID)
+ ChromeTracingDelegate::RegisterPrefs(registry);
StartupBrowserCreator::RegisterLocalStatePrefs(registry);
// The native GCM is used on Android instead.
gcm::GCMChannelStatusSyncer::RegisterPrefs(registry);
@@ -422,10 +428,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
extensions::launch_util::RegisterProfilePrefs(registry);
ExtensionWebUI::RegisterProfilePrefs(registry);
extensions::ExtensionPrefs::RegisterProfilePrefs(registry);
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
ToolbarActionsBar::RegisterProfilePrefs(registry);
extensions::CopresenceService::RegisterProfilePrefs(registry);
-#endif
RegisterAnimationPolicyPrefs(registry);
#endif // defined(ENABLE_EXTENSIONS)
@@ -484,7 +488,9 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
signin::RegisterProfilePrefs(registry);
#endif
-#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
+ // TODO(bshe): Revisit this once it is more clear on what should we do with
+ // default apps on Aura Android. See crbug.com/564738
+#if (!defined(OS_ANDROID) || defined(USE_AURA)) && !defined(OS_CHROMEOS)
default_apps::RegisterProfilePrefs(registry);
#endif
« no previous file with comments | « no previous file | chrome/browser/prefs/incognito_mode_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698