Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1487683006: Fix for exception in FixProcessor._addFix_illegalAsyncReturnType. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for exception in FixProcessor._addFix_illegalAsyncReturnType. This fixes the following reported exception. Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor The null object does not have a getter 'offset'. NoSuchMethodError: method not found: 'offset' Receiver: null Arguments: [] R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cfc8ee30b7af9442e08b0497a50686dfcf81703c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -96 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 4 chunks +76 lines, -96 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-01 22:22:28 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-01 22:34:52 UTC) #2
scheglov
5 years ago (2015-12-01 22:37:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfc8ee30b7af9442e08b0497a50686dfcf81703c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698